CRM-21733: Set status override end date to null if no 'Override until selected date' is not selected #11722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selected date' is not selected
|
Merging as a follow on pr |
|
@omarabuhussein see https://lab.civicrm.org/dev/core/issues/276 - regression - probably trivial https://lab.civicrm.org/dev/core/issues/276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This a complementary PR for this one #11622, it is to fix the issue mentioned here by @eileenmcnaughton #11622 (comment) where changing the override type from "until date" to either "no" or "permanent" but 'until date' does not get changed to null and its value stay on the old date.
Before
Changing the membership Status Override? field value from 'Override until selected date' to either Override Permanently or No will keep the status override end date value as is.
After
Changing the membership Status Override? field value from 'Override until selected date' to either Override Permanently or No will set the status override end date to NULL (empty value).