ensure pdfFilename is set #11702
Merged
ensure pdfFilename is set #11702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid setting the filename to a non-existent variable.
jitendrapurohit
approved these changes
Feb 23, 2018
There was a problem hiding this comment.
Agree with the changes as I see $invoiceNumber is not initialized anywhere in the file and was a wrong assignment. It was removed in https://github.com/civicrm/civicrm-core/pull/10681/files#diff-182432c905361c156662ac29df474a99 . ping @eileenmcnaughton @colemanw
|
@jmcclelland Does this have a related ticket? |
|
works fine. |
|
Hi Yashado, No related ticket. I wasn't sure where we are in the process of moving the issue tracker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid setting the filename to a non-existent variable.
Overview
When downloading a PDF file receipt, the name you are prompted to save it as is not properly set. If it simply set to: .pdf.
Before
After
The downloaded file name is named after the invoice id.
Technical Details
The pdf filename is properly set in the file, but then overwritten in later, incorrect code. I have simply removed the incorrect code that overwrites the properly set variable.