CRM-21781 Don't crash CiviCRM when missing contact ID #11690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good change :) |
|
possibly should be in the rc? |
|
ah - no - it's long-standing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In various situations you end up at civicrm/contact/view without URL parameters (for example logging back in after session expiry). Currently this crashes CiviCRM with a fatal error.
This PR changes it so that instead it bounces back to the Civi dashboard, improving the user experience.
Before
Browse to civicrm/contact/view and civi crashes
After
Browse to civicrm/contact/view and civi bounces back to the dashboard and gives a status message indicating that contact ID was not found.