CRM-21766 quash reload warning on dedupe conflicts screen #11670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colemanw wanna check this - it's the solution you used elsewhere & the page is basically a selection of actions so the message should go |
|
unrelated fail - will kick it in hope of a pretty green tick though |
|
test this please |
|
Yep, makes good sense. |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Mar 20, 2018
civicrm#11670 Change-Id: Iad0ddd2d32d5998df0681745549875d2ea54c608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After doing a batch merge the results are shown with various button options. Ensure these buttons can be clicked without a warning message about losing data (there is no place to enter data here.)
Before
After
Buttons respond without message
Technical Details
This is an extension of the fix made in https://issues.civicrm.org/jira/browse/CRM-21304
Comments