CRM-17647: fix unit tests and backoffice/live event form to use skipCleanMoney #11647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @eileenmcnaughton |
|
@monishdeb I think you need to make sure the number is > 1000 for the tests to catch them |
|
Authorize.net failing. There is some overlap with my ones so maybe we can separate them out? Also, I have been trying to make sure the form is cleaning them as early on as possible |
|
Ohh I am going to close this PR in favor of #11646 . As your patch is better :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a followup PR to fix all the test failures encountered in #11539 which highlights the fact that Event backoffice forms / online event page need skipCleanMoney attribute set in contribution params before financial processing. Also, fix other unit-tests to avoid using BAO fn to create contribution instead of API.