fix dev/core#1: allow to search contributions that are in progress

[tttp]

Overview

https://lab.civicrm.org/dev/core/issues/1

The search is hiding the status "in progress". However, some payment processor do use this status (eg the sepa one), so it is in effect hiding contributions, and therefore makes the users very sad and confused

Fix:
allow to search on status "in progress". Worse case scenario, no contributions have this status, and it will return an empty list

[civicrm-builder]

Can one of the admins verify this patch?

[eileenmcnaughton]

worst PR template / pr description ever :-) Can we get jenkins to love you?

[eileenmcnaughton]

add to whitelist

[tttp]

@eileenmcnaughton @Jenkins, sorry, I thought it would get more explanation from lab.civicrm.org (and proudly playing with issue 1 with @mlutfy at the sprint. Let me fix the PR description

[eileenmcnaughton]

I'm OK with merging this on the basis that those statuses should be removed from the Contribution option group (which is now separate from the pledge one) if not in use & that they are hard-coded & should not be.

@pradpnayak @monishdeb @jitendrapurohit ping

[monishdeb]

+1 👍

[tttp]

@eileenmcnaughton you mean removed by default or leave the option to each install to disable/hide them?

ie. some extensions blindly assume that these statuses are there and would break in not so nice ways if they aren't there

[eileenmcnaughton]

Merged since @monishdeb agreed with me :-)

@tttp I think new installs have 2 separate option value groups (pledge status & contribution status) and may not have those options in the contribution. I suggest if you are running one of those extensions you might want to add a function/ check to ensure that

civicrm_api3('Contribution', 'getoptions', ['field' => 'contribution_status_id]);

Has what you need in it.