CRM-21665 Fix check number toggle on Edit form when context is search #11611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this & it was able to replicate the bug & see it fixed. The code change is consistent with our habit of using a uniqueName for a field. I wondered if this would affect smart groups but I could not create a smart group from contribution search and a smart group created by advanced search was unaffected - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Check Number toggle on Edit form not work when context is search
Before
Check Number show / hide not working when user search the contribution (Find Contribution) then Edit the contribution in pop up box.
It work on contribution dashboard and under 'Contribution' Tab for contact.
Reason for not working on Find Contribution page: we have two field with same html ID 'payment_instrument_id'
( 1st from find contribution from (payment method) and 2nd is from contribution form)
ID has to be uniq. Since its duplicate jQuery unable to handle show hide functionality when Payment Method changed in Contribution Form.
After
Check number field get toggled when payment method change.
Technical Details
Same ID 'payment_instrument_id' present two times on page