CRM-21718: Don't choose 'print_contacts' as default task if it is not there

[johanv]

Overview

If you remove 'print contacts' from the search tasks by implementing hook_civicrm_searchTasks, every search form stops working.

Before

If you remove 'print contacts' from the search tasks by implementing hook_civicrm_searchTasks, every search form stops working.

After

Now it works.

Technical Details

It seems that in some part of the code for some reason the 'print contacts' is selected as default action, which causes troubles if it is not there.

---

• CRM-21718: If you remove 'Print selected rows' using hook_civicrm_searchTasks, search forms stop working

[mattwire]

@johanv I think this will affect all search tasks, not just contacts. Could you wait until #11240 is merged and then refactor this?

[johanv]

Ok, just ping me when I should look at this again.

[eileenmcnaughton]

@johanv - can you test again against master - hopefully you can close this out now

[eileenmcnaughton]

@johanv Can you test the latest rc - I believe this is now fixed due to @mattwire's work. Closing this

[johanv]

Thank you @eileenmcnaughton and @mattwire for your work. Sorry that it took me so long to look at this again, but since I changed jobs I don't have a lot of time for CiviCRM.
But tonight I finally found some time to look at this again. Unfortunately using the current master branch does not solve my issue.

So, I created an extension, and I implemented hook_civicrm_searchTasks like this:

function test_civicrm_searchTasks($objectType, &$tasks) {
  if ($objectType != 'contact') {
    return;
  }

  foreach ($tasks as $key => $value) {
    if ($value['title'] == 'Print selected rows') {
      unset($tasks[$key]);
    }
  }

  return;
}

In CiviCRM 4.7.29 with the patch in this pull request, this would remove the item 'Print selected rows' from the search tasks.
With the current CiviCRM master branch, this does nothing.
I used my debugger, and it turned out that in the current master branch, $objectType is null. I assume this is a bug. But for testing purposes, I removed the first return statement, and in that case, I got this error message:

 Fatal error: require_once(): Failed opening required '.php' (include_path='/opt/ext/be.johanv.test/:/var/www/html/sites/all/modules/civicrm/tools/extensions/cividiscount/:/var/www/html/sites/all/modules/civicrm/tools/extensions/civisualize/:/var/www/html/sites/all/modules/civicrm/tools/extensions/org.civicoop.civirules/:/var/www/html/sites/all/modules/civicrm/tools/extensions/civivolunteer/:/var/www/html/sites/all/modules/civicrm/tools/extensions/org.civicrm.angularprofiles/:.:/var/www/html/sites/all/modules/civicrm/:/var/www/html/sites/all/modules/civicrm//packages:.:/var/www/html/sites/all/modules/civicrm:/var/www/html/sites/all/modules/civicrm/packages:/var/www/html/sites/all/modules/civicrm/vendor/tecnickcom:/var/www/html/sites/all/modules/civicrm/vendor/phpseclib/phpseclib/phpseclib:/var/www/html/sites/all/modules/civicrm/vendor/pear/pear_exception:/var/www/html/sites/all/modules/civicrm/vendor/pear/auth_sasl:/var/www/html/sites/all/modules/civicrm/vendor/pear/net_socket:/var/www/html/sites/all/modules/civicrm/vendor in /var/www/html/sites/all/modules/civicrm/CRM/Core/Controller.php on line 451

Unfortunately, I don't have time to look further into this tonight. Maybe another time.

[eileenmcnaughton]

@johanv @mattwire please test #11861