fix select SMS recipients query #11589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @eileenmcnaughton @JKingsnorth i note that @monishdeb has already done a PR on this here #11558 and i'm not sure which is better option |
|
I am happy with this fix, but the PR #11558 also adds the missing code for smart group. Can I include this commit in my PR? So to keep all the fixes at one place :) |
|
Would be good to keep it in one place. Then I'm happy to re-review it. |
|
Closing this PR in favor of #11558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending a mass SMS is currently broken due to an error in the CRM_Mailing_BAO_Mailing::getRecipients query, which I think happened in this commit.
@monishdeb - you might want to take a look at the change.
I'm happy to write a test to accompany this if someone wants to give me a pointer on an appropriate unit to test.