CRM-21647 - Fatal error on deleting any contribution record #11500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
1 similar comment
|
test this please |
|
I replicated this bug & agree this fixes the problem |
|
test this please |
1 similar comment
|
test this please |
|
looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix fatal error on delete contribution form.
Before
Fatal error is displayed on
Delete Contributionform.After
Fixed. User is able to delete any contribution record.
Technical Details
It seems it was rendering the whole form where it needs to only display the delete button. This change forces the buildForm() function to return much before in case of a delete action.
Comments
The change of addField() was done recently in #10841