CRM-13123 - Fix serialization metadata for uf group type field #11472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seamuslee001 since you're familiar with its predecessor can you give this PR a quick look? |
|
@totten turns out we needed SERIALIZE_COMMA after all. |
|
@colemanw this looks fine to me, Just wondering when did we merge the other PR? just wondering if its needed on 4.7.30-rc branch or not? |
|
Thanks for the review @seamuslee001. There's no rush for a particular release since Api4 is still in active development. |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-13123 - Fix serialization metadata for uf group type field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Non-functional change to update schema metadata. A followup of #11394