CRM-21612: Membership Payment not recorded for recurring contribution…

[jitendrapurohit]

… when status label is changed

Overview

Membership Payment not recorded for recurring contribution when contribution status is changed.

Before

When a Pending contribution label is changed, recurring contribution done through a payment processor does not link to the membership.

After

Membership Payment is recorded correctly.

Technical Details

Due to label present in $statuses, the returned $result does not contain a value for payment_status_id, which do not create any membership contribution for the contact.

Comments

Added unit test.

---

• CRM-21612: Membership Payment not recorded for recurring contribution when status label is changed.

[seamuslee001]

(CiviCRM Review Template WORD-1.0)

• (r-jira) Pass
• (r-test) Pass Adds a unit test
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Not run - haven't tested this yet
• (r-user) Pass
• (r-tech) Pass - Uses standard practices to look up labels

[colemanw]

Anyone able to run this?

[mattwire]

As the default machine names/labels for contribution_status are the same for english language this will only have broken for non english installs. The fix looks correct, $statuses is only used within that function and if a match is not found payment_status_id will not be set. So this fix should make no difference for english installs, but should fix an issue for non-english installs. Note this may also explain why there is limited understanding of whether membership actually renews when a contribution is updated, as it has not been working for the last 2 years if you don't run CiviCRM in english!

[jitendrapurohit]

Note that this fails for english installs too, IF the default label is being changed. I've fixed this for a client using English site where Pending contribution status label was Pending or free trial.

As this may not be the most common case, I've tagged the JIRA as Minor as it only affects the site with non-default contribution status name. But just don't want this patch to be considered as the fix for only non-english installation :-).

[mattwire]

@jitendrapurohit Yes :-)

[eileenmcnaughton]

I'm merging this - I feel the code is clear enough that the test coverage + Jitendra's own testing is clear enough.