CRM-21599: Added missing structure in templates #11457
Conversation
| </div> | ||
| <div style="height: auto; vertical-align: bottom">{$form.eventsByDates.html}</div> | ||
| <td> | ||
| <label>{ts}Event Nanme{/ts}</label> |
There was a problem hiding this comment.
Typo - should be "Event Name". Can you get this from $form.title.label?
| @@ -72,4 +73,5 @@ | |||
| {crmButton q="action=add&reset=1" id="newLocationType" icon="plus-circle"}{ts}Add Option{/ts}{/crmButton} | |||
| {crmButton p="civicrm/admin" q="reset=1" class="cancel" icon="times"}{ts}Done{/ts}{/crmButton} | |||
| </div> | |||
| </div> | |||
There was a problem hiding this comment.
How is this file related to field name change?
There was a problem hiding this comment.
@pradpnayak This is not just for adding label. PR is to make the structure proper and this file adds missing wrapper around the content like other files.
There was a problem hiding this comment.
Should I understand :) as approved then?
There was a problem hiding this comment.
@pradpnayak can you do that from above Review changes then? for others to know the status
|
I am not sure if its a great idea to have label for the text field since there is enough description about the usage of the field. I will this to core team to decide. I have tested this locally and it works as expected. However, I am not confident of having 'templates/CRM/Admin/Page/LocationType.tpl' file included in this PR. Is it some how related to the fix? And also can you squash the commits? |
|
@pradpnayak
Description should always depict more about field but, it is the label that ultimately tells people what the field is for. |
|
I am not opposed to these change but like @pradpnayak said we already had an inline description for this field. But still, if we need to show the label then we also need to made such changes to other Search forms like:
@mukeshcompucorp would you like to discuss the PR on our dev channel https://chat.civicrm.org/civicrm/channels/dev ? |
|
Tested the PR and works for me. Doesn't bring any unintended change for the additional fixes made in localtionType.tpl. But next time please bring the indentation fixes or any NFC changes in separate PR. Manage Event page after applying this patch: |
CRM-21599: Added missing structure in templates
Overview
This PR
templates/CRM/Admin/Page/LocationType.tplEvent Nameof event attemplates/CRM/Event/Form/SearchEvent.tplBefore
After
Technical Details
Tabing and spacings are improved