CRM-21595 re-fix CRM-21445 #11454
CRM-21595 re-fix CRM-21445 #11454
Conversation
|
FWIW I applied this fix to an affected site and can confirm that it fixes the problem. |
|
@eileenmcnaughton I'm confused about this PR. It's against the 4.7.29.rc branch but that version has already been released. |
|
@eileenmcnaughton this should really go against 4.7.30-rc given that 4.7.29 has been released |
|
@seamuslee001 @colemanw Eileen suggested that 4.7.29 be re-cut and the existing download replaced on account of this being a critical bug - it causes contribution/event pages to fatal/WSOD. She said this here: #11427 (comment) I'm not taking a position one way or another on that - I don't know everything I should in order to have a useful opinion. Since she's on holiday, I wanted to make sure her position was represented. |
|
@MegaphoneJon I agree. Its much more critical bug and will affect users badly. We might also want to put up a blog post to notify unsuspecting users hold off upgrade till next plans are figured out. |
|
Yeh i see the point i guess we haven't had a practice of re-uploading a tar ball but given how critical this is it might be worth it. However if we get it into 4.7.30-rc then its only about what 2 weeks off that release. I certainly don't know what is the best course of action here. I agree with Yash that we need core team's input |
|
Jenkins re test this please |
1 similar comment
|
Jenkins re test this please |
|
Due to the criticality of this I have merged to 4.7.30 & master - #11483 - however, I still advocate replacing the 4.7.29 tarball with one with this fix asap |
|
too late for this now - closing |
Overview
Revert https://github.com/civicrm/civicrm-core/pull/11427/files
Add additional check for pay later fatal