Fix CRM-21589: "Repeat Contributions" report ignores sort. #11446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested the patch on my local and confirmed that this fixes the sort issue. Here's the screenshot: Before
After
|
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
…bution_report_sort Fix CRM-21589: "Repeat Contributions" report ignores sort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The "Repeat contribution" report ignores the settings under the "Sort" tab.
Before
See overview.
After
The report honors the settings under the "Sort" tab.
Technical Details
This report has its own postProcess() method, which until now omits code to include an "ORDER BY" clause honoring the configured "Sort" options. This PR changes two lines to make sorting work.