Reformat DAO files to pass linting and use short array syntax #11418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b41f439 to
3010d6b
Compare
|
@totten let's merge this after the 4.7.30-rc is cut. |
|
@mlutfy will you please ask jenkins to retest this once you've upgraded php on the apache side of our ci? |
|
@mlutfy this is highly prone to merge conflicts so ping me as soon as you get PHP upgraded on our CI server and I'll do a regen + rebase. |
|
jenkins, test this please |
3010d6b to
5e2d78f
Compare
|
I have rebased the PR, lets wait for the test build to pass. |
|
@monishdeb did you regenerate the dao files when you rebased? |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
Reformat DAO files to pass linting and use short array syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Our code standards covered every file in the core repo except the autogenerated DAOs. This cleans them up to pass
civilintstandards. It also makes them the first set of files to use the short array syntax now that we've officially dropped support for php 5.3 :)Before
DAO*.php files were a bit unsightly.
After
Code looks much better.
Technical Details
We really need to get ourselves a better php prettifier. I had to do some regex hacks to get the output to come out ok.