-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase minimum php version requirements #11416
Conversation
@totten this refactors a function in the install script so you'll want to merge this before tackling that rewrite. |
jenkins, test this please |
2 similar comments
jenkins, test this please |
jenkins, test this please |
@civicrm-builder test this please |
This makes it a little easier to hack and simulate different PHP versions.
@colemanw I pushed up a couple small tweaks. I was diff --git a/CRM/Upgrade/Incremental/General.php b/CRM/Upgrade/Incremental/General.php
index 56a80610d2..c97acf55ef 100644
--- a/CRM/Upgrade/Incremental/General.php
+++ b/CRM/Upgrade/Incremental/General.php
@@ -65,7 +65,7 @@ class CRM_Upgrade_Incremental_General {
*/
public static function setPreUpgradeMessage(&$preUpgradeMessage, $currentVer, $latestVer) {
$dateFormat = Civi::Settings()->get('dateformatshortdate');
- if (version_compare(phpversion(), self::MIN_RECOMMENDED_PHP_VER) < 0) {
+ if (version_compare('5.3.20', self::MIN_RECOMMENDED_PHP_VER) < 0) {
$preUpgradeMessage .= '<p>';
$preUpgradeMessage .= ts('You may proceed with the upgrade and CiviCRM %1 will continue working normally, but future releases will require PHP %2 or above. We recommend PHP version %3.', array(
1 => $latestVer, and the resulting message was this, which seems to suggest that you could continue with an upgrade on PHP 5.3: |
Hmm, @totten a fatal error ought to be triggered before we get to that screen, oughtn't it? Perhaps because you only changed the variable in one place that didn't happen. |
Thanks, @colemanw. Makes sense now. 👍 |
@totten based on discussion on dev-post-release I've cherry-picked this into the 4.7.29-rc branch. |
Increase minimum php version requirements
Overview
As promised in our blog post we are incrementing the minimum php requirements for CiviCRM.
Issue is here: https://lab.civicrm.org/infrastructure/ops/issues/818
Before/After
* We'll bump this to 5.5 in the following release as promised.