[NFC] CRM-21548 Remove unused variable and param from CRM_Utils_Address::format #11403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went through the function & calling functions and agree the code is not used & this is a useful tidy up |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
[NFC] CRM-21548 Remove unused variable and param from CRM_Utils_Address::format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The $contactName variable in this function was un-used.
The logic that created it is therefore unused.
Removing that meant that one of the parameters in the method was unused.
This should be a non-functional change. But areas to test are
Before
Addresses and contact display names were formatting correctly.
After
Addresses and contact display names are formatting correctly.
Technical Details
n/a
Comments
n/a