CRM-21489 document new constant in civicrm.settings.php #11336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
mattwire
reviewed
Feb 20, 2018
| * (ie. the database is locked by another transaction). This is an | ||
| * advanced setting intended for high-traffic databases & experienced developers/ admins. | ||
| */ | ||
| define('CIVICRM_DEADLOCK_RETRIES', 3); |
There was a problem hiding this comment.
Is this adding the define in when it wasn't already added? Or was it defined/defaulted elsewhere?
There was a problem hiding this comment.
it's new - but requires the merge in packages too
|
Associated packages PR has been merged so merging this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Document constant from civicrm/civicrm-packages#197 in civicrm.settings.php
Comments
This is just signposting / documenting a change discussed elsewhere - ie. JIRA & the other PR