CRM-21465 - avoid fatal error when clicking through pledge email. #11305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When setting up a pledge, an email message is sent with a link you can use to make a contribution against your pledge. When you click on this link, you get a backtrace.
Before
When clicking on the pledge link, you get a back trace.
After
When clicking on the link, you get a form to fill in your contribution amount.
Technical Details
This is a start - if I'm not missing anything obvious I can add a test. But for now, it seems that calling CRM_Core_DAO::commonRetrieveAll against a table with returnProperties set to a field that is not in the table shouldn't wor.