CRM-21461: Case Dashlet enhancement #11304
Conversation
f24fac6 to
00b753c
Compare
| @@ -530,17 +537,27 @@ public static function getCaseActivityQuery($type = 'upcoming', $userID = NULL, | |||
|
|
|||
| if ($condition) { | |||
| // CRM-8749 backwards compatibility - callers of this function expect to start $condition with "AND" | |||
| $query .= " WHERE (1) $condition "; | |||
| $query .= " WHERE (1) AND $condition "; | |||
There was a problem hiding this comment.
the AND threw an error. see getNextScheduledActivity -- the $condition that's passed to this already has an AND prefixed, resulting in a double AND. actually -- that error occurred in the contact's case tab. removing the AND throws errors in the dashlet. so we need to do some code review to make sure $condition is passed to this function in a consistent way.
There was a problem hiding this comment.
Ahh ok, my bad will fix it and will check its usage on other places to avoid regression.
709bdbd to
dc0adf1
Compare
|
Jenkins test this please |
| <th data-data="manager" data-orderable="false" class="crm-case-manager">{ts}Manager{/ts}</th> | ||
| <th data-data="date" cell-class="crm-case-date">{if $list EQ 'upcoming'}{ts}Next Sched.{/ts}{elseif $list EQ 'recent'}{ts}Most Recent{/ts}{/if}</th> | ||
| <th data-data="links" data-orderable="false" class="crm-case-links"> </th> | ||
| </th> |
There was a problem hiding this comment.
closing tag should be "tr"
|
this looks great. dashlets are much more dynamic and flexible now. @colemanw can you review and merge. |
|
Code looks great. Merging based on Brian's testing. |
Overview
Before
Case Dashboard:
Case Dashlets:
After
Case Dashboard:
Case Dashlets:
