CRM-21411 Fix issue where unsubscribe group field would not show beca… #11258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use CRM.crmMailing.groupNames was empty
|
Jenkins re test this please |
|
Fuzion deployed this to our staging site and, after executing Cleanup Caches the unsubscribe group field is back. |
|
Merging based on @joannechester testing |
totten
added a commit
to totten/uk.co.vedaconsulting.mosaico
that referenced
this pull request
Nov 27, 2017
Upstream made some changes in how the list of groups is supplied (CRM-21411, circa v4.7.28). This patch ports the change from civicrm/civicrm-core#11258. Note the use of `CRM.crmMailing.testGroupNames || CRM.crmMailing.groupNames` is intended to provide compatibility with older and newer protocols.
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21411 Fix issue where unsubscribe group field would not show beca…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…use CRM.crmMailing.groupNames was empty
Before
unsubscribe group field doesn't show
After
Now it does
Technical Details
because CRM.crmMailing.groupNames is now dynamically populated checking to see if it was set immediately as the JS loaded was causing scope.isUnsubGroupRequired to be set to false incorrectly and hence hiding the unsubscribe group section
Comments
@joannechester @KarinG @eileenmcnaughton could one of you please test this to test it create a CiviMailing from an advanced search and you should see the Unsubscribe Group field show. You may need to disable asset chaching under the debugging settings to ensure the updated code is used.