CRM-21363 Only implement ONLY_FULL_GROUP_BY if it is in the default g… #11249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seamuslee001 success! MACOS mariadb 10.2.10 I applied this patch and #11248 Let me know if I need to test one by one. I also tested against 4.7.28-RC and it fixes the issue there. Can we get these applied to the RC branch? |
|
@kcristiano note this is aimed at the RC branch which should then be forward ported to -> master ping @eileenmcnaughton @monishdeb @totten |
|
Merging based on test by @kcristiano & as a recent regression |
|
@seamuslee001 Thanks I missed the target branch. |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21363 Only implement ONLY_FULL_GROUP_BY if it is in the default g…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lobal sql_modes
@mattwire @kcristiano Matt Kevin can you test this out on your Maria servers and see if things settle down at all? also ping @monishdeb