CRM-21392 Allow viewing groups/smartgroups as as other entities (eg. memberships, events) #11241
Conversation
f296255 to
c5266a1
Compare
|
jenkins, test this please |
74ac340 to
425623e
Compare
425623e to
653b01e
Compare
653b01e to
bb0dab8
Compare
|
test this please |
bb0dab8 to
fecb40f
Compare
|
@lcdservices Is this something you would be able to test/review for me? It's related to #12244 as it exposes the ability to "View As activities/memberships" etc. just like you can do in Advanced search but via the Manage Groups page. |
|
@mattwire sorry for the delay reviewing this. I implemented and tested and it works as expected. It's a really nice addition to the manage group page! |
|
@eileenmcnaughton Can you tag as "sig:user interfacing improvement" |
|
I took a look at the code & it seems largely sensible and contained to the screen @lcdservices tested so merging based on @lcdservices testing @mattwire ideally we would make this a standard behaviour - the add to group - or was this the missing outlier? |
|
@eileenmcnaughton Can you explain "@mattwire ideally we would make this a standard behaviour - the add to group - or was this the missing outlier?" I don't quite understand |
|
@mattwire I mean - does this now work on all component searches? |
| @@ -102,6 +102,16 @@ public static function tasks() { | |||
| 'class' => 'CRM_Member_Form_Task_PDFLetter', | |||
| 'result' => FALSE, | |||
| ), | |||
| self::SAVE_SEARCH => array( | |||
There was a problem hiding this comment.
@mattwire this is the part of the change I'm focussed on
There was a problem hiding this comment.
@eileenmcnaughton Yes, I'm pretty sure it does. When I added it to CRM/Member/Task I was being cautious but ideally we'd move this into CRM_Core_Task - not sure I've time to thoroughly test that change though at the moment but the groundwork should all be in place for that to be done in the future.
Overview
Add a filter to the "Find Groups" page which changes the "Contacts" link to the selected entity type:
Before
You can only view groups from the "Find Groups" screen by Contacts.
After
Add a filter to the "Find Groups" page which changes the "Contacts" link to the selected entity type:
Technical Details
The underlying code for groups already supports this and it is already exposed in advanced search criteria.