CRM-21337 ISO compliance for Romanian and Bulgarian counties #11168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've put this in against 4.7.28, but I can make it 'sooner' if you like. |
|
I don't see any urgency to merge against 4.7.27-rc. It's been like that for a very long time. Thanks for the PR! (merge on pass) |
|
Thanks for the review |
|
Jenkins can you retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We use ISO 3166-2 for county/state names. We noticed there were some spellings that were not consistent with this standard in CiviCRM for Bulgaria and Romania.
Before
County spellings were not standard.
After
County spellings meet the standard.
Technical Details