CRM-21315: (intra-rc regression) pay_later processor showing up in list of available processors #11141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list of available processors
|
Tested on Contribution, Event and Membership backoffice form and confirmed that weird Merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…list of available processors
Overview
The pay-later process is visible to select & needs to be filtered out again
Before
visible in payment processor select box on back office forms
After
gone from the forms I've tested
Comments
I didn't test front end forms. Note that I also moved the decision regarding whether to display ($this->_mode) into the shared function. Probably all these payment forms should have a shared buildFormCommon which calls this & some other shared things