CRM-20432: Change Membership status to current when related contribution payment is recorded from pending status.

[agilewarealok]

Overview

Pending Contributions which then have a payment recorded are marked completed but do not trigger the related Membership to become current. Membership status remains pending.

Follow the steps to reproduce the bug:

1. Using membership type, no price set and default status rules
2. Add membership to contact, set payment status to pending
3. Note contribution status is pending
4. Note membership status is pending
5. Record payment for the contribution
6. Note contribution status is now completed
7. Note membership status is still pending
8. Bug membership status should be current

Before

Recording payment did not update Membership status to current from Pending.

After

It now works as expected, when a pending contribution payment is recorded we update the Membership status to Current.

Technical Details

We've created a unit test for this to prevent failing the above case.

Agileware Ref: CIVICRM-550

---

• CRM-20432: CIVICRM-221 Pending Contributions which have a Payment recorded and are Completed do not trigger the related Membership to become current, status remains pending

[civicrm-builder]

Can one of the admins verify this patch?

[monishdeb]

@agilewarealok I cannot replicate this bug in dmaster, please check my screencast below:

I believe this was fixed in #11006

[agilewarealok]

@monishdeb
Yeah It's working as expected. Actually we had this patch to submit some times back, looks like the bug is fixed.

I've removed the patch which was updating the membership status and kept the Unit test as it is. I think that would be helpful to include.

[monishdeb]

Absolutely, thanks for adding UT to ensure the fix. Will merge it on test build pass

[monishdeb]

@agilewarealok there is a related test build failure - https://test.civicrm.org/job/CiviCRM-Core-PR/17601/ And I agree with this failure that membership status should be New not Current as calculated from membership's start,end and join dates.

[jusfreeman]

And I agree with this that membership status should be New not Current as calculated from membership's start,end and join dates.

@monishdeb so what is your recommendation here? Is it to fix the #11006 logic as part of this PR?

[monishdeb]

No the #11006 logic is correct. So I am suggesting that 'Current' should be changed to 'New' here https://github.com/civicrm/civicrm-core/pull/11125/files#diff-ec7ce0ba112f5e88dc1d12b6972e09f5R220.

[agilewarealok]

@monishdeb Pushed the code with suggested changes.

[monishdeb]

@agilewarealok great :) One last thing ..can you rebase your PR to remove the false merge commit - 44210fe

Steps to rebase:

$ git fetch upstream master
$ git pull --rebase upstream master
$ git push -f origin CRM-20432

[agilewarealok]

@monishdeb I hope it looks good now :)

[monishdeb]

Indeed :) merged

[monishdeb]

Thanks for your work @agilewarealok