CRM-21304 quash form reload message when refreshing #11122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
|
Works locally, no work lost by reloading except resetting the result pager |
---------------------------------------- * CRM-21304: Dedupe usablity, quash refresh message in more cases https://issues.civicrm.org/jira/browse/CRM-21304
|
@eileenmcnaughton that didn't work for me, but this did. (commit added) |
|
@colemanw Ok - that seems to be working.... merging |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
* CRM-21304 quash form reload message when refreshing * CRM-21304 - Disable unsaved changes warning on dedupe form ---------------------------------------- * CRM-21304: Dedupe usablity, quash refresh message in more cases https://issues.civicrm.org/jira/browse/CRM-21304
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Feb 1, 2018
civicrm#11122 Bug:T177873 Change-Id: Ib3cbb754b77720687fcb47f53e02bf798f751dfb
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Feb 2, 2018
civicrm#11122 Bug:T177873 Change-Id: Ib3cbb754b77720687fcb47f53e02bf798f751dfb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Says huuuush to this message
Before
Above message suppressed when navigating away from the dedupe find screen by clicking a button (actually a redirect)
After
Above message also suppressed when reloaded or otherwise navigating away
Comments
There is no information stored on this page/form that would be worrisome to lose. Treat as a page, not a form