Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs CRM-21268 Missing French overseas departments. #11076

Merged
merged 1 commit into from
Oct 8, 2017

Conversation

nowszy
Copy link
Contributor

@nowszy nowszy commented Oct 6, 2017

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@seamuslee001
Copy link
Contributor

Jenkins ok to test

@seamuslee001
Copy link
Contributor

Jenkins retest this please

1 similar comment
@seamuslee001
Copy link
Contributor

Jenkins retest this please

@seamuslee001
Copy link
Contributor

ping @eileenmcnaughton @totten i have tested the upgrade locally and confirmed it adds in the overseas territories correctly. This is good to merge

@nowszy
Copy link
Contributor Author

nowszy commented Oct 8, 2017

Why tests have failed? It seems to be not related to my changes.

@seamuslee001
Copy link
Contributor

@nowszy the test failure was a temporary failure due to geocoding limits. I have got the system to re-run the tests and they now pass

@mlutfy
Copy link
Member

mlutfy commented Oct 8, 2017

I reviewed the code and had a quick look at the test site that was generated. I also note that 4.7.26 being branched, 4.7.27 is the correct file. Merging.

Thanks @nowszy @seamuslee001 !

@mlutfy mlutfy merged commit 94e178c into civicrm:master Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants