CRM-21202, set retrieve = true so that its not reinitialized again an… #11004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colemanw can you please review this for us? |
…d just want the DataTable instance to be returned ---------------------------------------- * CRM-21202: DataTables warning: table id=dupePairs https://issues.civicrm.org/jira/browse/CRM-21202
c71e58f to
3db1e4a
Compare
|
Test failure is unrelated. |
|
Jenkins retest this please |
1 similar comment
|
Jenkins retest this please |
|
@colemanw Just tested this out - Confirmed I see the datatables warning as posted in JIRA by following steps outlined there (Create a couple of duplicate contacts, use a generic dedupe rule to find them, select them for batch merge), and no longer get the warning after this patch. It does not appear to affect functionality at all (batch merge works as expected both before the patch if you click through the message and ignore it, and after the patch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d just want the DataTable instance to be returned
https://issues.civicrm.org/jira/browse/CRM-21202
Before