CRM-21117: Line item not shown when paying later using membership priceset #10978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test this please |
monishdeb
reviewed
Sep 15, 2017
| @@ -1664,6 +1664,8 @@ protected function postProcessMembership( | |||
|
|
|||
| $emailValues = array_merge($membershipParams, $form->_values); | |||
| $emailValues['membership_assign'] = 1; | |||
| $emailValues['useForMember'] = !empty($form->_useForMember); | |||
There was a problem hiding this comment.
Or what if $emailValues['useForMember'] = (bool) $form->_useForMember);
|
I'm going to merge this - I don't think @monishdeb's comment is a blocker & the code change seems fine + locked in with a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Line item not shown when paying later using membership priceset.
Before
No line item displayed in mails with below steps.
1/ Create a membership priceset with one select and one text field. Add this to a contribution page.
2/ Signup using pay later
3/ No line item is displayed in invoice received.
After
Line items are shown correctly.
Comments
Added unit test.