CRM-21149 ts fix for "(including yourself)" on the Event Registration Form

[agileware]

Overview

On Event Registration Form, cannot target the text "(including yourself)" using word replacement because the parenthesis is outside the ts markers

See https://issues.civicrm.org/jira/browse/CRM-21149

Before

"including yourself" can be translated, but cannot translate "(including yourself)"

After

Can translate "(including yourself)"

Technical Details

Moves location of ts tags

Comments

Have submitted PR for civicrm/l10n#17 as well

[seamuslee001]

@mlutfy do you have any comments on this from an internationalisation perspective?

[eileenmcnaughton]

@mlutfy ping - this probably just needs a quick comment from you

[jcorlew]

Jenkins please retest this

[jcorlew]

Jenkins retest this

[colemanw]

Jenkins retest this

[jcorlew]

Jenkins retest this please

[colemanw]

Jenkins retest this please

[jcorlew]

I'll be testing this when the build completes

[alifrumin]

Jenkins retest this please

[jcorlew]

We tested this successfully
Test process:
Created a new site with dmaster
Created a new event "Sprint Test 1," enabled online registration and enabled "register multiple participants"
Made changes in Word Replacement (Administer --> Custom Data & Screens --> Word Replacement)
(including yourself) to change to parantheses

Before the patch the replacement did not take effect
After the patch the replacement worked

@mlutfy we believe this is ready to merge if you don't have any international concerns

[mlutfy]

This would break existing string overrides that people may have put in place, however:

• the ts usage was indeed wrong, since I consider this to be typographic. Typography should always be included in the translation string. Different languages might handle or use parenthesis differently.
• we change strings all the time, so "expect random breakage from overriden strings" is the current status quo.

Thank you for the patch & review!