CRM-21125 allow class assignment on report row links #10922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monishdeb
reviewed
Sep 7, 2017
| <td class="crm-report-{$field}{if $header.type eq 1024 OR $header.type eq 1 OR $header.type eq 512} report-contents-right{elseif $row.$field eq 'Subtotal'} report-label{/if}"> | ||
| {if $row.$fieldLink} | ||
| <a title="{$row.$fieldHover}" href="{$row.$fieldLink}"> | ||
| <a title="{$row.$fieldHover}" href="{$row.$fieldLink}" {if $row.$fieldClass} class="{$row.$fieldClass}"{/if}> |
There was a problem hiding this comment.
@eileenmcnaughton won't there always be $row.$fieldClass so to omit IF condition, as we are already ensuring the fieldName to be present at L115?
There was a problem hiding this comment.
hmm but if empty it would be class="" - would that be ok?
There was a problem hiding this comment.
if empty then we don't have that link at all
There was a problem hiding this comment.
So the data would look like this
$row => array(
'financial_type_id' => 'Donation',
'financial_type_id_link' => 'https....',
'contact_type' => 'Individual',
'contact_type_link' => 'https....',
'contact_type_hover' => 'Click to popup contact',
'contact_type_class' => 'crm-pop-up',
);
|
Tested, working fine |
|
thanks @monishdeb |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Feb 1, 2018
Assists with dedupe analysis as I am using this to provide pop-ups on analysis reports rather than forcing click throughs to see more. civicrm#10922 Change-Id: I5369a58035fef294b58c2dd1a89519c069d46443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows report writers to assign a class when defining a link on a cell
Before
Not possible to assign a link
After
Possible, but no change in any existing reports / behaviour. Extra steps are required in the reports themselves to leverage
Technical Details
an example usage is on JIRA