CRM-21106 Add Warnings about new required extension to support Financ… #10904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A warning seems good to me. I'm not sure if a status check message is necessary. I'll let Joe speak to that. Will this "upgrade warning" improvement be available in the next nightly build RC? |
|
@Stoob it would be once it is merged, and will be available depending on when its merged from 4.7.25 or 4.7.26 perhaps (putting aside Eileen's point about going to 5.0) |
|
Jenkins re test this please |
fce720d to
6dfd787
Compare
|
@eileenmcnaughton i have made the language bit more non version specific and i think this will do what we want at least giving notice |
…ial Type ACLs in reports CRM-21106 Make language less urgent indicating it will in the futre need the extension
6dfd787 to
5c3f581
Compare
|
I'm going to merge this now so it hits the rc - @Stoob are you able to test the 4.7.25 rc which will have this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ial Type ACLs in reports
Overview
Add in a warning if Financial ACL Report extension is not installed in systems. Which is now required to support the working of the Financial Type Acls
@Stoob @eileenmcnaughton @pradpnayak I think this will help, Is someone able to test this out? This should emit a warning before doing an upgrade and also after an upgrade as a status check message