CRM-21098 #10892
CRM-21098 #10892
Conversation
js/crm.backdrop.js
Outdated
| @@ -0,0 +1,14 @@ | |||
| // http://civicrm.org/licensing | |||
| CRM.$(function($) { | |||
| $(document).on('crmLoad', function(e) { | |||
There was a problem hiding this comment.
You don't need this wrapper. We're already waiting for document.ready because of the CRM.$(function()... construct
js/crm.backdrop.js
Outdated
| // http://civicrm.org/licensing | ||
| CRM.$(function($) { | ||
| $(document).on('crmLoad', function(e) { | ||
| $('#admin-bar').css('display', 'none'); |
There was a problem hiding this comment.
Simpler to use the .hide() method.
There was a problem hiding this comment.
For some reason I don't get the same results when using .show() and .hide(). I can't get it to hide the Backdrop admin bar on page load with .hide() and using .show() on the clicks seems to interfere with the page load as well.
js/crm.backdrop.js
Outdated
| $('#admin-bar').css('display', 'none'); | ||
| }); | ||
| $('.crm-hidemenu').click(function(e) { | ||
| $('#admin-bar').css('display', 'block'); |
js/crm.backdrop.js
Outdated
| $('.crm-hidemenu').click(function(e) { | ||
| $('#admin-bar').css('display', 'block'); | ||
| }); | ||
| $('#crm-notification-container').click(function(e) { |
There was a problem hiding this comment.
Better to do $('#crm-notification-container').on('click', '#crm-restore-menu', function() {
There was a problem hiding this comment.
Thanks. I was wondering how to attach it to #crm-restore-menu.
CRM/Utils/System/Backdrop.php
Outdated
| */ | ||
| public function appendCoreResources(&$list) { | ||
| $list[] = 'js/crm.backdrop.js'; | ||
| } |
There was a problem hiding this comment.
Yes this function is redundant now.
|
@colemanw ready for another review. I've had mixed results with using .hide()/.show() compared to using .css() for this. I'm not sure why. |
|
@herbdool I just pushed a change to the restore menu click handler. Give it a try on your local to ensure it works. |
|
@colemanw oops, thanks for restoring that. It works for me locally. |
Overview
Prevent Backdrop admin menu dropdowns appearing beneath the CiviCRM admin menu by hiding the Backdrop admin menu when the CiviCRM admin menu is visible and also to show the Backdrop admin menu when the CiviCRM admin is hidden.
Before
Backdrop admin menu is visible beneath the CiviCRM admin menu.
After
Backdrop admin menu is hidden when CiviCRM admin menu is visible.
Technical Details
Adds a crm.backdrop.js file for Backdrop installs.
Comments
This PR might need to be slightly updated if #10891 is merged first.