CRM-21089 - CiviSurvey - Fix fatal error on 'Interview Respondents' #10885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to replicate the bug & confirm the patch fixes it. In addition the patch makes sense and only adds to the from clause, rather than altering it or removing from it. merging. Thanks for the clear information to reproduce in Jira @MegaphoneJon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Attempting to use "Interview Respondents" in CiviSurvey results in a fatal error. See CRM-21089 for details on how to replicate.
Before
See above.
After
Fatal error no longer exists.
Technical Details
This is a SQL error that results from
civicrm_campaignnot being added to the FROM clause of the SQL statement. This patch calls the function that adds the correct FROM statement when building a query from within CiviSurvey.