CRM-21068 - getLastModified fails more gracefully now.

[rtobias81]

Overview

This helps resolve some errors when trying to view contacts.

Before

Without this change, there were cases were some contacts were throwing Not Of Type Integer errors in the Contact Summary view (from getDisplayAndImage).

After

This change makes the getLastModified fail more gracefully, so it doesn't display an error if something is missing for a contact when getDisplayAndImage is called from the Summary View.

Technical Details

Comments

---

• CRM-21068: &lastModified() fails more gracefully.

[civicrm-builder]

Can one of the admins verify this patch?

[mattwire]

@rtobias81 As discussed on chat.civicrm.org :-)

[mattwire]

This comment doesn't have much meaning once this change is committed and should probably be removed. It's more of a "commit message" comment

[mattwire]

For me, I might want a short comment explaining why we check modified_id

[totten]

jenkins, ok to test

[eileenmcnaughton]

@rtobias81 do you know how to deal with the style warnings? We use drupal whitespace conventions
https://www.drupal.org/docs/develop/standards/coding-standards.

[rtobias81]

Not really. Or at least not if it is anything other than just going back and fixing the spacing issues. It helps when you can see (I didn't realize I didn't have the right indenting for the function declaration). That said, I saw it complaining about stuff in lines 71-90something, which I find odd as I only replaces lines 48-69. Can I just commit my fixed function declaration spacing and rerun the test to see if that fixed other issues?

[eileenmcnaughton]

Yep, if you fix the spaces & do git commit --amend & then git push -f to keep it clean jenkins will try again

[eileenmcnaughton]

@rtobias81 this looks good. I want to push you a little more for a couple of bits of tidy up

1. edit the PR description to fill in the fields above (overview, before after)
2. this is kinda more advanced git - but your commits have wound up with messages that don't accurately describe them. Can you have a go at tidying them up. The way to do it is (assuming your remote branch for the core repo is called 'upstream', change to 'origin' or whatever if not'
   git rebase -i upstream/master
   You will then see a list of commits in vi or similar, on the second one change the word 'pick' to 's' for 'squash'. It will then squash the 2 commits together & give you a chance to edit the message.

When you push to your branch on github you will need to use -f as you are rewriting history (you didn't know the past could be changed so easily!)

[eileenmcnaughton]

add to whitelist