Fix CRM-21058: Add support for events to Personal Campaign Page Report. #10862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a minor change affecting one report with high quality pr description (inclusive of before & after screenshots) so I'm happy to merge it on the basis of the information reported |
|
FWIW, that PR description template is 90% responsible for the quality of the description; I just did the 10% of following it. |
|
OK - I take all credit away from you & give it to @mickadoo then :-) |
|
Credit where due! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix for CRM-21058.
Since PCP can now be associated with Events, this PR adds the filter for Event Title alongside the filter for Contribution Page Title. It also renames the column "Contribution Page Title" to "Page Title" and adds a new column, "Page Type," which will say either "Event" or "Contribution".
Before
After
Technical Details
Nothing noteworthy.
Comments
None.