CRM-20913 use pledge option group for pledge payments #10803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jitendrapurohit I merged this but I think 'IN Progress' needs to be 5 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up fix for #10737
Before
Pledge payment picking up wrong status as picked up in unit tests on extended report extension https://test.civicrm.org/job/CiviCRM-Core-Matrix/CIVIVER=master,label=ubuntu1204/3987/
After
works again
Technical Details
refer #10790
Comments
@eileenmcnaughton Updated value of
Overdueto match withcontribution_status.Reverted
payment_statusto retrieve from contribution status for this release. I'll include this in next PR to update pledge_payment status to retrieve its value frompledge_statusas I think that will include more file changes and would be tested well with time.