CRM-21004 only remove html snippet task if setting enabled #10802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkin test this please |
|
@lcdservices alternatively this could be implemented as https://gist.github.com/monishdeb/f37ae22c27c410acb3db082d8421bc29 as Apart from that it's working fine |
|
@monishdeb agreed -- I think that's better. It accounts for other circumstances where the html snippet action may not be present. updated the PR. |
monishdeb
approved these changes
Aug 3, 2017
There was a problem hiding this comment.
Tested working fine. @colemanw / @eileenmcnaughton can you please review and merge this PR?
Thanks!
|
Looks like @lcdservices & @monishdeb have agreed the fix here & my role is just to click go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enable profile copy for mixed use profiles when html snippet is disabled.
Technical Details
Fixes a regression since the "accept profile submissions from external sites" setting was added. The html snippet action was getting removed twice if that setting was turned off, which resulted in the copy action also being removed.