CRM-21000 : Fix DB error on Advance Search Mailings #10798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this and confirms that it fixes it. @eileenmcnaughton |
|
Thanks for the review @seamuslee001 & the patch @jitendrapurohit - the patch makes sense & I'm happy with Seamus's testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This Fixes DB Error on Advance Search if results are displayed as Mailings.
Before
Incorrect join of
civicrm_contribution.campaign_idin the query leads to DB error.After
Correct joins are formed based on mailing or contribution
Technical Details
Campaign Filter was added in #6527. This change aims to add join for campaign before
Component::fromis called so that correct join is added forcampaign_idw.r.t mailing or contribution.