CRM-17040 Import Contributions using External Ids causes … #10797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…soft credit to be wrongly associated
|
This seems to make sense to me @eileenmcnaughton does it make sense to you? |
|
This PR now has a test for the soft credit import. |
|
@seamuslee001 ready for review dude! :) |
|
Yay tests! The actual import change to the code base seems trivial & clearly thought add. Added test coverage = big yay. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…soft credit to be wrongly associated
Overview
From CRM-17040, When importing contributions where BOTH the donor and the soft credit recipient are specified by External ID, then the contribution is allocated to the soft credit user not the donor.
Before
Soft credit is not assigned to the donor when using the External ID
After
Soft credit is assigned to the donor when using the External ID
Technical Details
CSV contribution import tested before patch, error repeatable.
After patch, CSV contribution assigns soft credits correctly.
Comments
Code was overriding the contact_id value of the primary contact by the soft_credit contact.
https://issues.civicrm.org/jira/browse/CRM-17040