CRM-20990 add contributionStatus to online template #10793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendrapurohit
approved these changes
Aug 7, 2017
|
@monishdeb @colemanw looking for a merger here |
|
@eileenmcnaughton in exchange can you merge this PR #10814 !! 😃 This would allow me to work on CRM-20998 (against 4.7.25) as it's dependent on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add $contributionStatus to templates assigned to Online message template (also used for sending receipts from contribution search)
Before
$contributionStatus var not available
After
$contributionStatus var available & unit tested
Technical Details
Comments
@seamuslee001 @monishdeb @jitendrapurohit this gives me the nuance to improve my templates , but I wonder if there is an issue affecting other people regarding changing in pay_later assignment - pinging you guys in case anything is on your radar.