CRM-20855: Disabling "Search Primary Details Only" causes partial CiviMail delivery failure #10746
Conversation
monishdeb
commented
Jul 24, 2017
•
- CRM-20855: Disabling "Search Primary Details Only" causes partial CiviMail delivery failure
…iMail delivery failure
|
Confirmed that this resolves the bug 👍 |
|
Thanks @mfb and @lcdservices for your feedback @colemanw / @eileenmcnaughton can you merge this PR? |
| // Search by Primary location type ONLY if searchPrimaryDetailsOnly setting is on OR | ||
| // search query is trigerred via api OR | ||
| // special parameter search_by_primary_details_only = TRUE | ||
| self::$_alwaysSearchByPrimaryOnly = (Civi::settings()->get('searchPrimaryDetailsOnly') || $apiEntity || !empty($params['search_by_primary_details_only'])); |
There was a problem hiding this comment.
I think the api should set $params['search_by_primary_details_only'] rather than $apiEntity being code for that.
There was a problem hiding this comment.
@eileenmcnaughton didn't found the exact spot set search_by_primary_details_only = 1 via all API params that uses location type. Reason why the earlier code used $apiEntity. Or can you suggest me where could we set this parameter for API?
|
@monishdeb test is good & underlying logic is good. I'm less keen on what variables are being set where & what they are being relied on to do. I put my thoughts in a separate PR https://github.com/civicrm/civicrm-core/pull/10915/files (wanted to see what will happen with tests on it) - but basically I think we should consolidate on existing parameters & be explicit about passing in searchPrimary rather than overloading the 'apiEntity' which already has an ambiguous relationship to 'mode' |
|
Closing in favor of #10915 |