Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed test class. #10730

Merged
merged 2 commits into from
Aug 29, 2017
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

I wonder if this test was running before?

@eileenmcnaughton
Copy link
Contributor Author

I'm giving this a merge on pass since it is simply fixing a mis-named test class & jenkins is the reviewer here

@seamuslee001
Copy link
Contributor

@eileenmcnaughton test failures are related not sure if that was why maybe test class was renamed but not sure if we should dig in before merging this

@eileenmcnaughton
Copy link
Contributor Author

perhaps they never worked :-( @monishdeb you wrote some of this test class... recall anything

@monishdeb
Copy link
Member

Jenkins test this please

eileenmcnaughton and others added 2 commits August 23, 2017 16:10
I wonder if this test was running before?
@seamuslee001
Copy link
Contributor

@eileenmcnaughton jenkins appears to be happy now

@eileenmcnaughton
Copy link
Contributor Author

All hail jenkins!

@eileenmcnaughton eileenmcnaughton merged commit db8010b into civicrm:master Aug 29, 2017
@eileenmcnaughton eileenmcnaughton deleted the test_name branch August 29, 2017 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants