regen.sh - Fix stale function call in sql/GenerateData.php #10706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [civicrm#10463](civicrm#10463), the function signature of `getInstrumentFinancialAccount()` changed slightly -- in that the parameter became mandatory. Grepping for other calls to `getInstrumentFinancialAccount()` shows that one of the unit-tests works with example input `4`, so this does the same. Before ====== Running "regen.sh" fails -- because `getInstrumentFinancialAccount` is called without a parameter. After ===== Running "regen.sh" completes -- because `getInstrumentFinancialAccount` is called with `4`. Acceptance Prompts ================== * The example data produced by `regen.sh` should contain suitable/similar values for financial records. * Determine whether `4` is a suitable value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10463, the
function signature of
getInstrumentFinancialAccount()changed slightly -- in thatthe parameter became mandatory.
Grepping for other calls to
getInstrumentFinancialAccount()shows that one of the unit-testsworks with example input
4, so this does the same.Before
Running "regen.sh" fails -- because
getInstrumentFinancialAccountis called without a parameter.After
Running "regen.sh" completes -- because
getInstrumentFinancialAccountis called with4.Acceptance Prompts
regen.shshould contain suitable/similar values for financial records.4is a suitable value.(Ping participants from previous PR: @pradpnayak @monishdeb @colemanw)