CRM-20915: Creating credit card registration for event stores payment method as check #10701
Conversation
monishdeb
commented
Jul 19, 2017
•
- CRM-20915: Creating credit card registration for event stores payment method as check
|
Works as expected after patch. |
|
@monishdeb @Edzelopez this works & makes sense but I really wanted to add tests on this. Unfortunately there were no existing tests on this form :-( However, I created a test, (which required some extraction) here #10725 for that class. The test DOES demonstrate this bug with the addition of one line to the bottom of the test class I have left that line out because I wanted to submit it passing. If you can review & confirm the extraction & get that merged and then add that line to this PR then I will be happy to merge this pr |
…class. Although the failing assertion is not present, this test demonstrates the bug described in CRM-20915. It also adds initial test to the form
|
@eileenmcnaughton I have reviewed and cherry-picked the commit from #10725. Also added that extra line. Please have a look! |
|
@monishdeb great - I'm happy to merge this - as long as you confirm that you did take a look at my patch & make sure I didn't do anything dumb (now this PR has both our code & I can confirm I am happy with & have reviewed the code you wrote) |
|
@monishdeb this is ok to merge from my pov - do you want to confirm my part looks ok to you? |
|
@eileenmcnaughton yup just did a quick test on my local. Did event registration w/o live mode and it works fine, didn't cause any unintended regression. Ok to merge 👍 |