CRM-20764 Allow clean URLs with CiviCRM on Backdrop #10674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seamuslee001
requested changes
Jul 16, 2017
| @@ -443,6 +443,9 @@ if (!defined('CIVICRM_CLEANURL')) { | |||
| if ( function_exists('variable_get') && variable_get('clean_url', '0') != '0') { | |||
| define('CIVICRM_CLEANURL', 1 ); | |||
| } | |||
| elseif { function_exists('config_get') && config_get('system.core', 'clean_url') != 0) { | |||
There was a problem hiding this comment.
@herbdool there is also a php error here
PHP Parse error: syntax error, unexpected '{', expecting '(' in /home/jenkins/buildkit/build/core-10674-4ayju/sites/default/civicrm.settings.php on line 464
|
@seamuslee001 thanks, I've attempted your request and fixed the syntax error. |
|
@herbdool there's a false merge commits in the PR (see the 2nd commit). To avoid that, always rebase your current branch then rebase. Here are the steps to do that :
|
|
@monishdeb how about now? |
|
Perfect 😃👍 |
|
@monishdeb @herbdool Any reason why this hasn't been merged yet? |
|
@mlutfy I'm not sure why it hasn't been merged. I think it's ready. |
|
Code looks good to me |
|
OK, taking the liberty of merging this one, based on the comments/reviews. |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-20764 Allow clean URLs with CiviCRM on Backdrop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://issues.civicrm.org/jira/browse/CRM-20764