CRM-17748: Expose options to CRM_Core_DAO

[monishdeb]

• CRM-17748: Expose options['result_buffering'] to CRM_Core_DAO

[lcdservices]

this looks good. ran a test running the same query through executeQuery and executeUnbufferedQuery and confirmed the unbuffered format was working as expected.

[seamuslee001]

@eileenmcnaughton I think this makes sense, code looks sensible, Brian appears to have tested it and confirmed working

[eileenmcnaughton]

I'm pretty much ready to merge based on the combined review of @seamuslee001 & @lcdservices + seeing that the code looks good & appears to only impact when a specific, not normal, path is followed. I do recall last time we tried to expand this code there was a problem with exports - but I think that was only because I tried to make it call executeUnbufferedQuery from the export function & this doesn't. @monishdeb do you remember?

[monishdeb]

@eileenmcnaughton yes and that's still an issue for export, where we cannot use unbufferedQuery. I stated the reason here

[eileenmcnaughton]

@monishdeb but nothing in this pr gives you pause?

[monishdeb]

Yes. The patch just exposes the underlying DB options as listed here And unbuffered queries still work for single (NOT nested) queries.

[eileenmcnaughton]

cool - merging