CRM-20789 Fix unsubscribing when link comes from an AB Test #10583
Conversation
seamuslee001
commented
Jun 29, 2017
•
- CRM-20789: Unsubscribing from an AB test does not work in 4.7.21
CRM-20789 Fix retrieving entity when in AB test context
|
Just commenting this has been tested by AUG works in both AB and non ab testing modes |
|
This was a bug introduced i believe in 4.7.20 hence why i have put it against the RC |
|
@eileenmcnaughton does this look ok to you? |
…ensure only deailing with AB tests
|
@jitendrapurohit Jitendra as you last did work in this area does this make sense to you? |
|
sure, will test this later today. |
|
ok - I wasn't able to replicate this on my local. Steps I performed was -
Also tried with including/excluding previous mailing in step 2 - same result. Please let me know if you think I'm missing anything. |
|
|
||
| // If $entity is null and $mailing_Type is either winner or experiment then we are deailing with an AB test | ||
| $abtest_types = array('experiment', 'winner'); | ||
| if (empty($entity) && in_array($mailing_type, $abtest_types)) { |
There was a problem hiding this comment.
I understand this aims to fix the query when $entity (entity_table column from civicrm_mailing_group) is NULL, but it always gets set to some value for me whether I choose recipients to be existing group(sets to civicrm_group) or previous mailing(civicrm_mailing).
There was a problem hiding this comment.
@jitendra was $mailing_id resolving to the id of the A Mailing or the B Mailing or the Final. We were finding issues when $mailing_id = the b or final and there was nothing in the mailing_group table for the b or final.
There was a problem hiding this comment.
For me - mailing_group api called here always ensured entity_table to set to either group or mailing. And if it doesn't in your case, not sure but shouldn't the fix be more likely to set this column instead of fixing the query if it is empty ?
Update - the above user tag just notified another jitendra on github, for me it is @jitendrapurohit :-)
There was a problem hiding this comment.
@jitendrapurohit the issue for me is that in civicrm_mailing_group the only records there are for the A mailing so when someone clicks a link that is linked to either the mailing id of B or Final then $entity ends up being entity as there are no records for those mailings in civicrm_mailing_group
There was a problem hiding this comment.
Okay - based on the last comment by seamus, this makes sense when a unsub url from a mailing not present in civicrm_mailing_group is triggered in the url(though I wasn't able to replicate). And its seems to be pretty safe and modifies the code only for the ab test type mailings with limited scope.